ajantha-bhat commented on a change in pull request #4132:
URL: https://github.com/apache/carbondata/pull/4132#discussion_r635772654
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortParameters.java
##########
@@ -532,7 +556,7 @@ public static SortParameters
createSortParameters(CarbonDataLoadConfiguration co
parameters.setNoDictSortDataType(noDictSortAndNoSortDataTypes.get("noDictSortDataTypes"));
parameters.setNoDictNoSortDataType(noDictSortAndNoSortDataTypes.get("noDictNoSortDataTypes"));
// keep partition columns in the end for table spec by getting
rearranged tale spec
- TableSpec tableSpec = new
TableSpec(configuration.getTableSpec().getCarbonTable(), true);
+ TableSpec tableSpec = new
TableSpec(configuration.getTableSpec().getCarbonTable(), false);
Review comment:
Some more scenario is that we can check like,
iv) more than one partition column (one int, one string) and more than one
sort column for above scenarios.
v) static partition and dynamic partition together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
