akkio-97 commented on a change in pull request #4129:
URL: https://github.com/apache/carbondata/pull/4129#discussion_r638743477
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##########
@@ -195,18 +275,31 @@ private[sql] case class
CarbonAlterTableColRenameDataTypeChangeCommand(
var deletedColumnSchema: ColumnSchema = null
var schemaEvolutionEntry: SchemaEvolutionEntry = null
val columnSchemaList =
tableInfo.fact_table.table_columns.asScala.filter(!_.isInvisible)
+ // to validate duplicate children columns
+ var UniqueColumnSet: mutable.Set[String] = mutable.Set()
Review comment:
I feel this this place was okay to validate it. In
validColumnsForRenaming() we only have a list of table columns. Also in
validateComplexStructure() we traverse only the specific column that is being
altered.
Only columnSchemaList contains all columns (not only altered column but also
other columns) as a flat structure,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
