vikramahuja1001 commented on a change in pull request #4141:
URL: https://github.com/apache/carbondata/pull/4141#discussion_r655300176
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/binary/TestBinaryDataType.scala
##########
@@ -1551,26 +1552,28 @@ class TestBinaryDataType extends QueryTest with
BeforeAndAfterAll {
sql("insert into hive_table select 'a','b','1'");
}
- val e2 = intercept[SparkException] {
- sql("insert into hive_table2 select 'a','b','binary'");
- }
+ if (!SparkUtil.isSparkVersionXAndAbove("3")) {
+ val e2 = intercept[SparkException] {
+ sql("insert into hive_table2 select 'a','b','binary'");
+ }
- assert(e2.getMessage.contains(
- "Dynamic partition strict mode requires at least one static
partition column"))
+ assert(e2.getMessage.contains(
+ "Dynamic partition strict mode requires at least one static
partition column"))
- val eInt2 = intercept[Exception] {
- sql("insert into hive_table2 select 'a','b','1'");
- }
+ val eInt2 = intercept[Exception] {
+ sql("insert into hive_table2 select 'a','b','1'");
+ }
- val e3 = intercept[SparkException] {
- sql("insert into parquet_table select 'a','b','binary'");
- }
+ val e3 = intercept[SparkException] {
+ sql("insert into parquet_table select 'a','b','binary'");
+ }
- assert(e3.getMessage.contains(
- "Dynamic partition strict mode requires at least one static
partition column"))
+ assert(e3.getMessage.contains(
+ "Dynamic partition strict mode requires at least one static
partition column"))
- val eInt3 = intercept[Exception] {
- sql("insert into parquet_table select 'a','b','1'");
+ val eInt3 = intercept[Exception] {
+ sql("insert into parquet_table select 'a','b','1'");
+ }
Review comment:
it is needed or else spark will not be able to find the path to the
carbon file
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/merge/MergeTestCase.scala
##########
@@ -842,7 +842,7 @@ class MergeTestCase extends QueryTest with
BeforeAndAfterAll {
Row("d", "3")
).asJava, StructType(Seq(StructField("key", StringType),
StructField("value", StringType))))
- initframe.write
+ initframe.repartition(1).write
Review comment:
it is needed or else spark will not be able to find the path to the
carbon file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
