akashrn5 commented on a change in pull request #4180:
URL: https://github.com/apache/carbondata/pull/4180#discussion_r695389629
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
##########
@@ -119,14 +119,18 @@
for (CarbonDimension tableDimension : tableComplexDimension) {
if (isColumnMatches(isTransactionalTable,
queryDimension.getDimension(),
tableDimension)) {
- ProjectionDimension currentBlockDimension = null;
+ ProjectionDimension currentBlockDimension;
// If projection dimension is child of struct field and contains
Parent Ordinal
if (null !=
queryDimension.getDimension().getComplexParentDimension()) {
currentBlockDimension = new
ProjectionDimension(queryDimension.getDimension());
} else {
currentBlockDimension = new ProjectionDimension(tableDimension);
+ // for complex dimension update datatype, set scale and
precision by traversing.
+ // Spark requires the resultant row with latest datatype,
+ // update the dimension here to collect the resultant rows with
updated datatype.
+
fillNewDatatypesForComplexChildren(currentBlockDimension.getDimension(),
+ queryDimension.getDimension());
}
- // TODO: for complex dimension set scale and precision by
traversing
// the child dimensions
Review comment:
remove this here and add along with new comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
