Indhumathi27 commented on a change in pull request #4218:
URL: https://github.com/apache/carbondata/pull/4218#discussion_r710295417
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java
##########
@@ -100,13 +102,15 @@ public ArrayDataType(String name, String parentName,
String columnId) {
* @param parentName
* @param columnId
* @param isDictionary
+ * @param nullFormat
*/
public ArrayDataType(String name, String parentName, String columnId,
- Boolean isDictionary) {
+ Boolean isDictionary, String nullFormat) {
Review comment:
We no need to handle this way. Here, compaction is failing because of
logging bad record error for inserting NULL for previous segments. Bad record
should be done for Load/Insert flow only. We can avoid performing Bad record
validation during compaction by passing a flag from global sort compaction
flow. Please revert these changes, as it might induce new issues if actual data
is NULL/empty data type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
