kunal642 commented on a change in pull request #4220:
URL: https://github.com/apache/carbondata/pull/4220#discussion_r718528557
##########
File path:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
##########
@@ -366,17 +366,27 @@ public boolean accept(CarbonFile pathName) {
*/
public List<String> getDeleteDeltaFilesList(final Segment segment, final
String blockName) {
List<String> deleteDeltaFileList = new ArrayList<>();
- String segmentPath = CarbonTablePath.getSegmentPath(
- identifier.getTablePath(), segment.getSegmentNo());
+ String segmentPath = null;
+ for (LoadMetadataDetails details: segmentDetails) {
Review comment:
check whether the segment is external before this loop like this:
if (segment.isExternalSegment) {
for (LoadMetadataDetails details: segmentDetails) {
...
}
} else {
segmentPath = CarbonTablePath.getSegmentPath(
identifier.getTablePath(), segment.getSegmentNo());
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
