Indhumathi27 commented on a change in pull request #4228:
URL: https://github.com/apache/carbondata/pull/4228#discussion_r733315196
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/InputProcessorStepWithNoConverterImpl.java
##########
@@ -443,8 +443,11 @@ private void getComplexTypeByteArray(Object[] newData, int
index, Object[] data,
try {
GenericDataType complextType =
dataFieldsWithComplexDataType.get(dataField.getColumn().getOrdinal());
- complextType
- .writeByteArray(data[orderedIndex], dataOutputStream, logHolder,
isWithoutConverter);
+ boolean isEmptyBadRecord = Boolean.parseBoolean(
+
configuration.getDataLoadProperty(DataLoadProcessorConstants.IS_EMPTY_DATA_BAD_RECORD)
+ .toString());
+ complextType.writeByteArray(data[orderedIndex], dataOutputStream,
logHolder,
Review comment:
```suggestion
complexType.writeByteArray(data[orderedIndex], dataOutputStream,
logHolder,
```
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonBadRecordUtil.java
##########
@@ -154,4 +158,23 @@ public static String getBadRecordsPath(Map<String, String>
loadOptions, CarbonTa
return badRecordsPath;
}
+ public static void updateEmptyValue(DataOutputStream dataOutputStream,
boolean isEmptyBadRecord,
+ BadRecordLogHolder logHolder, String parentName, DataType dataType)
throws IOException {
+ CarbonUtil.updateWithEmptyValueBasedOnDatatype(dataOutputStream, dataType);
+ if (isEmptyBadRecord) {
+ CarbonBadRecordUtil.setErrorMessage(logHolder, parentName,
dataType.getName());
+ }
+ return;
Review comment:
this statement is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
