kunal642 commented on code in PR #4280:
URL: https://github.com/apache/carbondata/pull/4280#discussion_r902364497
##########
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java:
##########
@@ -336,9 +336,10 @@ private String overwritePartitions(CarbonLoadModel
loadModel, LoadMetadataDetail
.filter(partitionList::contains).collect(Collectors.toList());
if (!overlappingPartitions.isEmpty()) {
List<LoadMetadataDetails> validLoadMetadataDetails =
- loadModel.getLoadMetadataDetails().stream().filter(
- loadMetadataDetail -> !loadMetadataDetail.getLoadName()
-
.equalsIgnoreCase(newMetaEntry.getLoadName())).collect(Collectors.toList());
+
loadModel.getLoadMetadataDetails().stream().filter(loadMetadataDetail ->
+
!loadMetadataDetail.getLoadName().equalsIgnoreCase(newMetaEntry.getLoadName())
+ &&
loadMetadataDetail.getSegmentStatus().equals(SegmentStatus.SUCCESS))
Review Comment:
LOAD_PARTIAL_SUCCESS should also be considered as valid segment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
