[ 
https://issues.apache.org/jira/browse/CARBONDATA-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359979#comment-15359979
 ] 

ASF GitHub Bot commented on CARBONDATA-31:
------------------------------------------

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/11#discussion_r69372525
  
    --- Diff: 
integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonStrategies.scala
 ---
    @@ -141,11 +138,7 @@ class CarbonStrategies(sqlContext: SQLContext) extends 
QueryPlanner[SparkPlan] {
             predicates,
             useUnsafeCoversion = false)(sqlContext)
           projectExprsNeedToDecode.addAll(scan.attributesNeedToDecode)
    -      val updatedAttrs = scan.attributesRaw.map(attr =>
    --- End diff --
    
    Let me check, these code doesn't need to delete.


> Unify definition for SparkContext,CarbonContext,HiveContext,SQLContext
> ----------------------------------------------------------------------
>
>                 Key: CARBONDATA-31
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-31
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: ChenLiang
>            Assignee: ChenLiang
>            Priority: Minor
>
> For SparkContext,CarbonContext,HiveContext,SQLContext definition, different 
> places having different definition, for example:
> 1)val sc = new CaronContext, val carboncontext = new CaronContext
> 2)var oc: HiveContext , var context: HiveContext
> ....
> To unify definition for SparkContext,CarbonContext,HiveContext,SQLContext as 
> below:
> CarbonContext : cc
> SQLContext : sqlContext
> SparkContext : sc
> HiveContext : hiveContext



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to