Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/176#discussion_r80179086
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/QueryStatisticsRecorderImpl.java
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.carbondata.core.carbon.querystatistics;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.carbondata.common.logging.LogService;
+import org.apache.carbondata.common.logging.LogServiceFactory;
+
+import static org.apache.carbondata.core.util.CarbonUtil.printLine;
+
+/**
+ * Class will be used to record and log the query statistics
+ */
+public class QueryStatisticsRecorderImpl implements
QueryStatisticsRecorder,Serializable {
+
+ private static final LogService LOGGER =
+
LogServiceFactory.getLogService(QueryStatisticsRecorderImpl.class.getName());
+
+ /**
+ * serialization version
+ */
+ private static final long serialVersionUID = -5719752001674467864L;
+
+ /**
+ * list for statistics to record time taken
+ * by each phase of the query for example aggregation
+ * scanning,block loading time etc.
+ */
+ private List<QueryStatistic> queryStatistics;
+
+ /**
+ * query with taskd
+ */
+ private String queryIWthTask;
+
+ /**
+ * lock for log statistics table
+ */
+ private static final Object lock = new Object();
+
+ public QueryStatisticsRecorderImpl(String queryId) {
+ queryStatistics = new ArrayList<QueryStatistic>();
+ this.queryIWthTask = queryId;
+ }
+
+ /**
+ * Below method will be used to add the statistics
+ *
+ * @param statistic
+ */
+ public synchronized void recordStatistics(QueryStatistic statistic) {
+ queryStatistics.add(statistic);
+ }
+
+ /**
+ * Below method will be used to log the statistic
+ */
+ public void logStatistics() {
+ for (QueryStatistic statistic : queryStatistics) {
+ LOGGER.statistic(statistic.getStatistics(queryIWthTask));
+ }
+ }
+
+ /**
+ * Below method will be used to show statistic log as table
+ */
+ public void logStatisticsAsTableExecutor() {
+ synchronized (lock) {
--- End diff --
Why this lock is required? It seems this is the only place lock is used?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
