Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/194#discussion_r80221140
--- Diff:
core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java ---
@@ -1401,8 +1401,7 @@ public static void logError(Throwable e, boolean
invalidRowsPresent) {
public static boolean nanSafeEqualsDoubles(Double d1, Double d2) {
Boolean xIsNan = Double.isNaN(d1);
Boolean yIsNan = Double.isNaN(d2);
- if ((xIsNan && yIsNan) || (d1.doubleValue() == d2.doubleValue())) {
-
+ if ((d1.doubleValue() == d2.doubleValue()) || (xIsNan && yIsNan)) {
--- End diff --
Boolean xIsNan = Double.isNaN(d1); these variables are already computed,
no use of moving them. Instead use ( Double.isNaN(d1) && Double.isNaN(d2))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
