Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/224#discussion_r82729006
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/scan/processor/AbstractDataBlockIterator.java
 ---
    @@ -127,11 +133,15 @@ protected boolean updateScanner() {
         }
       }
     
    -  private AbstractScannedResult getNextScannedResult() throws 
QueryExecutionException {
    +  private AbstractScannedResult 
getNextScannedResult(QueryStatisticsRecorder recorder,
    --- End diff --
    
    Why we need to change this getNextScannedResult() method  parameters. if 
required please pass a statistics model, this will make sure that our method 
parameters wont grow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to