Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404900 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -267,10 +267,10 @@ object GlobalDictionaryUtil extends Logging { } def isHighCardinalityColumn(columnCardinality: Int, - rowCount: Long, - model: DictionaryLoadModel): Boolean = { + rowCount: Long, + model: DictionaryLoadModel): Boolean = { (columnCardinality > model.highCardThreshold) && (rowCount > 0) && --- End diff -- move `(rowCount > 0)` to next line so that every condition is one line
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---