Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/219#discussion_r85459810
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -1143,6 +1141,21 @@ case class LoadTableUsingKettle(
val allDictionaryPath = options.getOrElse("all_dictionary_path", "")
val complex_delimiter_level_1 =
options.getOrElse("complex_delimiter_level_1", "\\$")
val complex_delimiter_level_2 =
options.getOrElse("complex_delimiter_level_2", "\\:")
+ val timeFormat = options.getOrElse("timeformat", null)
+ val dateFormat = options.getOrElse("dateformat", null)
+ val tableDimensions: util.List[CarbonDimension] =
table.getDimensionByTableName(tableName)
+ val dateDimensionsName = new ArrayBuffer[String]
+ tableDimensions.toArray.foreach {
+ dimension => {
+ val columnSchema: ColumnSchema =
dimension.asInstanceOf[CarbonDimension].getColumnSchema
+ if (columnSchema.getDataType.name == "TIMESTAMP") {
+ dateDimensionsName += columnSchema.getColumnName
+ }
+ }
+ }
+ if (dateFormat != null) {
+ validateDateFormat(dateFormat, dateDimensionsName)
+ }
--- End diff --
please move these code into method validateDateFormat
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
