On Thu, Feb 11, 2016 at 11:56 AM, Romain Hardouin <romainh...@yahoo.fr>
wrote:

> I targeted the dev list because I would like to know why the developer
> (patch by branimir and reviewed by benedict) mentions "Only supported with
> the Murmur3Partitioner" whereas his patch uses IPartitioner interface. (I
> will try to reach them on IRC if they don't see this message.)
>

While the patch uses the IPartitioner interface, it also requires that the
Token for the partitioner supported to implement the 2 new methods 'size'
and 'increaseSlightly', which only Murmur3Partition tokens does (it throws
UnsupportedOperationException for RandomPartitioner in particular).
So the documentation in the yaml is correct, only Murmur3Partitioner is
currently supported.

That said, I think the initial rational for only supporting
Murmur3Partitioner is that it's the default and the one recommended, but
it's certainly true that old installs are stuck to RandomPartitioner (and
honestly the difference with Murmur3 are not big enough that its worth
going through a very painful migration if that's your case) and it's not
immediately clear to me that adding support for it would be too hard. Feel
free to open an improvement ticket for that if you're interested.

--
Sylvain

Reply via email to