Good catch. Thanks everyone for speaking up about these.
Changing mine to -1 On Nov 10, 2016 2:44 AM, "Sam Tunnicliffe" <s...@beobal.com> wrote: > > -1 from me too due to #12877. I also agree with Alex's suggestion of > reverting #11990 and re-rolling. > > On Wed, Nov 9, 2016 at 1:20 PM, Oleksandr Petrov < oleksandr.pet...@gmail.com > > wrote: > > > -1 > > > > Sorry but I have to -1 that one, with the following explanation > > > > One of the features in 3.10 breaks SASI in quite a significant way. The > > issue was introduced in #11990 [1] and described in #12877 [2]. If there > > are more than 8 items in partition that have same index value, index file > > will get corrupted and returned results will be incorrect. > > > > I think we should rather revert the patch and go ahead with a release > > without it and change the patch to work correctly, possibly making it's > > scope slightly bigger. I am working on a design document for the change. > > > > [1] https://issues.apache.org/jira/browse/CASSANDRA-11990 > > [2] https://issues.apache.org/jira/browse/CASSANDRA-12877 > > > > On Wed, Nov 9, 2016 at 11:19 AM Gary Dusbabek <gdusba...@gmail.com> wrote: > > > > > +1 > > > > > > On Tue, Nov 8, 2016 at 8:09 PM, Michael Shuler <mich...@pbandjelly.org > > > > wrote: > > > > > > > I propose the following artifacts for release as 3.10. > > > > > > > > sha1: 072b5271a88328b909b230d0e30df1c7476fdb3f > > > > Git: > > > > http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a= > > > > shortlog;h=refs/tags/3.10-tentative > > > > Artifacts: > > > > https://repository.apache.org/content/repositories/ > > > > orgapachecassandra-1133/org/apache/cassandra/apache-cassandra/3.10/ > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/ > > > > orgapachecassandra-1133/ > > > > > > > > > > > > > > > > The Debian packages are available here: > > > > http://people.apache.org/~mshuler > > > > > > > > > > > > > > > > The vote will be open for 72 hours (longer if needed). > > > > > > > > > > > > > > > > [1]: (CHANGES.txt) https://goo.gl/TZa9a7 > > > > > > > > [2]: (NEWS.txt) https://goo.gl/FSI1a4 > > > > > > > > > -- > > Alex Petrov > >
