Caveat: I'm strongly in favor of us blocking a release on a non-green test board of either utest or dtest.
> put something in prod which is known to be broken in obvious ways In my experience the majority of fixes are actually shoring up low-quality / flaky tests or fixing tests that have been invalidated by a commit but do not indicate an underlying bug. Inferring "tests are failing so we know we're asking people to put things in prod that are broken in obvious ways" is hyperbolic. A more correct statement would be: "Tests are failing so we know we're shipping with a test that's failing" which is not helpful. Our signal to noise ratio with tests has been very poor historically; we've been trying to address that through aggressive triage and assigning out test failures however we need far more active and widespread community involvement if we want to truly *fix* this problem long-term. On Mon, Nov 21, 2016 at 2:33 PM, Jonathan Haddad <j...@jonhaddad.com> wrote: > +1. Kind of silly to put advise people to put something in prod which is > known to be broken in obvious ways > > On Mon, Nov 21, 2016 at 11:31 AM sankalp kohli <kohlisank...@gmail.com> > wrote: > > > Hi, > > We should not cut a releases if Dtest are not passing. I won't block > > 3.10 on this since we are just discussing this. > > > > Please provide feedback on this. > > > > Thanks, > > Sankalp > > >
