On Mon, Jun 12, 2023 at 10:18 AM Mick Semb Wever <m...@apache.org> wrote:
> > > On Mon, 12 Jun 2023 at 15:02, Maxim Muzafarov <mmu...@apache.org> wrote: > >> Hello everyone, >> >> I would like to make the source code of the Cassandra project more >> visible to people outside of the Cassandra Community and highlight the >> typical known issues in new contributions in the GitHub pull-request >> interface as well. This makes it easier for those who are unfamiliar >> with the accepted code style and just want to be part of a large and >> friendly community to add new contributions. >> >> The ASF provides [1] the SonarClound facilities for the open source >> project, which are free to use, and we can also easily add the process >> of building and uploading reports to the build using GitHub actions >> with almost no maintenance costs for us. Of course, as a >> recommendation quality tool, it doesn't reject any changes/pull >> requests, so nothing will change from that perspective. >> >> I've prepared everything we need to do this here (we also need to >> modify the default Sonar Way profile to suit our needs, which I can't >> do as I don't have sufficient privileges): >> https://issues.apache.org/jira/browse/CASSANDRA-18390 >> >> I look forward to hearing your thoughts on this. >> > > > Looks good. Agree with the use of GHA, but it's worth noting that this > cannot be a pre-commit gate – as PRs are not required. And if it came as > part of pre-commit CI, how would the feedback then work (as it's the jira > ticket that is our point-of-contact pre-commit) ? > > I say go for it. Especially with the post-commit trends it will be > valuable for us to see it before further adoption and adjustment. > I'd also say the same - Go for it, at worst people can ignore it, at best someone sees the data and decides to take action. If we eventually try to define a POLICY based on the feedback, I suspect it'll be a longer conversation, but I don't see any harm in setting it up.
