+1 (nb). I think this is a great addition to offline tools that use SSTable writer in general.
On 2023/10/23 23:21:13 Yifan Cai wrote: > Hi, > > I want to propose merging the patch in CASSANDRA-18941 to 4.0 and up to > trunk and hope we are all OK with it. > > In CASSANDRA-18941, I am adding the capability to produce size-bounded > SSTables in CQLSSTableWriter for sorted data. It can greatly benefit > Cassandra Analytics (https://github.com/apache/cassandra-analytics) for > bulk writing SSTables, since it avoids buffering and sorting on flush, > given the data source is sorted already in the bulk write process. > Cassandra Analytics supports Cassandra 4.0 and depends on the cassandra-all > 4.0.x library. Therefore, we are mostly interested in using the new > capability in 4.0. > > CQLSSTableWriter is only used in offline tools and never in the code path > of Cassandra server. > > Any objections to merging the patch to 4.0 and up to trunk? > > - Yifan >