It am okay with its use off hot paths in principle, and I’ve done it myself.
But as others have mentioned, it’s not obvious to every contributor what is and
isn’t a hot path. Also, the codebase is a living, shifting thing: a cold path
today can suddenly become hot tomorrow - it’s not uncommon.
Another benefit to this binary decision flow is that we can easily enforce it
with our lint tooling just for non-test part of the codebase. It’s just easier
to scale.
> On 7 Jun 2024, at 10:27, Štefan Miklošovič <stefan.mikloso...@gmail.com>
> wrote:
>
> I think it makes sense to use streams to make the life easier for a dev when
> constructing some log messages or something like that in clearly not hot
> paths. Nothing wrong with that ... Collectors.joining(", ") and that kind of
> stuff. I do not think that doing this aggressively and "orthodoxly" is
> necessary.
