Been working with Bruce and Ralf a bit on removing this log message that actually means nothing for people using LocalTransactionContext who commit/rollback as they should.

Bruce, the jar you sent didn't seem to do the trick but this change to the finalize method does the trick:

  protected void finalize() throws Throwable {
        if (_scope == null || !_ctx.isOpen() ) {
            return;
        }
                        
        if (_ctx instanceof LocalTransactionContext ||
(_ctx instanceof GlobalTransactionContext && ! _isPoolInUseForGlobalTransactions)) {
            // retrieve SQL bound to this Database instance
            OQLQuery oqlQuery = getOQLQuery();
            String sql = ((OQLQueryImpl) oqlQuery).getSQL();

_log.warn(Messages.format("jdo.finalize_close", this.toString(), _dbName, sql));
        }
        close();
  }


Aside from the annoying and false log message, I'd like to avoid the needless synchronized call to close() in the finalizing thread.

Anyway, this patch kosher?

--
David Blevins




-------------------------------------------------
If you wish to unsubscribe from this list, please send an empty message to the following address:

[EMAIL PROTECTED]
-------------------------------------------------

Reply via email to