Actually you may post a patch against 3.0 in Jira. We might give it a
try, running our test suite against all supported DBs.
Andrus
On Apr 2, 2010, at 5:19 PM, Andrus Adamchik wrote:
Hi Evgeny,
while we haven't planned to release 2.0.5 (after 3.0 final this will
likely become an unsupported version), this is not entirely out of
the question and I see no problem if we keep adding patches to 2.0
branch. Please also add a note to the corresponding RELEASE-
NOTES.txt file.
Regarding your Jira comment:
3.1 trunk is already fixed.
Why 2.0 should be patched? Because current logic (witch returns
driver specific types) is really far from our last release
( 2.0.4 ) which doesn't rely on drivers.
So I suggest to fix it in all branches (even 3.0 that is going to
release soon).
I'd rather we do not commit it to 3.0-STABLE just yet, as this is a
branch we'll use to cut the final release. However at some point
we'll tag 3.0-final and then 3.0-STABLE becomes open for 3.0.1
development where this patch can go. (or alternatively we can use
RC3 tag as a base for 3.0-final, but that is if we are optimistic
that no more bug fixes will go on 3.0 till final).
Thanks,
Andrus
On Apr 2, 2010, at 5:01 PM, evg...@apache.org wrote:
Author: evgeny
Date: Fri Apr 2 14:01:13 2010
New Revision: 930271
URL: http://svn.apache.org/viewvc?rev=930271&view=rev
Log:
CAY-1354 Wrong Types mapping for selected values in Row Queries
Move logic of Java type resolving from driver to Cayenne type
mapping.
Reason: Drivers can return here different types (even some specific
like com.oracle.TIMESTAMP)
Modified:
cayenne/main/branches/STABLE-2.0/cayenne/cayenne-java/src/cayenne/
java/org/apache/cayenne/access/jdbc/ColumnDescriptor.java
Modified: cayenne/main/branches/STABLE-2.0/cayenne/cayenne-java/src/
cayenne/java/org/apache/cayenne/access/jdbc/ColumnDescriptor.java
URL:
http://svn.apache.org/viewvc/cayenne/main/branches/STABLE-2.0/cayenne/cayenne-java/src/cayenne/java/org/apache/cayenne/access/jdbc/ColumnDescriptor.java?rev=930271&r1=930270&r2=930271&view=diff
=
=
=
=
=
=
=
=
=
=====================================================================
--- cayenne/main/branches/STABLE-2.0/cayenne/cayenne-java/src/
cayenne/java/org/apache/cayenne/access/jdbc/ColumnDescriptor.java
(original)
+++ cayenne/main/branches/STABLE-2.0/cayenne/cayenne-java/src/
cayenne/java/org/apache/cayenne/access/jdbc/ColumnDescriptor.java
Fri Apr 2 14:01:13 2010
@@ -153,7 +153,7 @@ public class ColumnDescriptor implements
this.qualifiedColumnName = name;
this.label = name;
this.jdbcType = metaData.getColumnType(position);
- this.javaClass = metaData.getColumnClassName(position);
+ this.javaClass =
TypesMapping.getJavaBySqlType(this.jdbcType);
}
/**
