Committed. Thanks a lot for the adapter. Andrus
On Jun 15, 2013, at 12:29 PM, Miłosz Pigłas <mil...@archeocs.com> wrote: > Hi, > > On 06/12/2013 08:47 PM, Andrus Adamchik wrote: >> >> On Jun 12, 2013, at 9:18 PM, Miłosz Pigłas<mil...@archeocs.com> wrote: >> >>> Test org.apache.cayenne.query.SelectQueryTest#testSelectLongIn(), ends with >>> error because of generated statement size and firebird limitations >>> (http://www.firebirdfaq.org/faq299/). Are such errors aceptable? >> >> For other DBs we used UnitDbAdapter as a means to suppress certain unit >> tests on some DBs. Although looking at this test, I am not quite sure what >> it tests :) I'd just remove this particular test actually. > > Actually I consider this test case quite as usefull. Before I run it I hadn't > known that I have to split very large IN statements (more than 1500 values) > on smaller parts. > > Firebird Adapter is ready: https://issues.apache.org/jira/browse/CAY-1836. > Please review it ;). > > Thanks, > Milosz > >
