Thanks, Ari. After your comment, I realized that I wasn't clicking in the right place to initiate a comment. I was clicking on the pencil icon rather than on the code itself. I haven't used github since April or March so I'm a bit out of practice.
Andrus, I don't know that we really need a policy if we're all in agreement and it's standard practice. On Tue, Sep 23, 2014 at 9:47 AM, Aristedes Maniatis <a...@maniatis.org> wrote: > None of us have admin rights there. But you should be able to still comment. > > Ari > > > On 23/09/2014 11:16pm, Mike Kienenberger wrote: >> Can someone add me to the cayenne github project so I can comment on >> pull requests? >> >> github username is the same: mkienenb >> >> Also, should we be insisting that github patches are "clean" and not >> containing extraneous commits? >> >> ie, ed8b7b0509ddfe216f035a2b7327a1b162a9167e and >> 8eb8defec3bc000c0a0e2c2e8f7330ce04e0c5ea dealing with the board >> reports in https://github.com/apache/cayenne/pull/14/commits (CAY-1951 >> Support ISO-8601 date/time Strings in Expressions #14) >> > > -- > --------------------------> > Aristedes Maniatis > GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
