FMX commented on code in PR #997:
URL:
https://github.com/apache/incubator-celeborn/pull/997#discussion_r1033064382
##########
common/src/main/java/org/apache/celeborn/common/meta/FileInfo.java:
##########
@@ -28,24 +28,39 @@
import org.apache.hadoop.fs.Path;
import org.apache.celeborn.common.identity.UserIdentifier;
+import org.apache.celeborn.common.protocol.PartitionType;
import org.apache.celeborn.common.util.Utils;
public class FileInfo {
private final String filePath;
private final List<Long> chunkOffsets;
private final UserIdentifier userIdentifier;
+ private final PartitionType partitionType;
public FileInfo(String filePath, List<Long> chunkOffsets, UserIdentifier
userIdentifier) {
Review Comment:
Done.
##########
common/src/main/java/org/apache/celeborn/common/meta/FileInfo.java:
##########
@@ -28,24 +28,39 @@
import org.apache.hadoop.fs.Path;
import org.apache.celeborn.common.identity.UserIdentifier;
+import org.apache.celeborn.common.protocol.PartitionType;
import org.apache.celeborn.common.util.Utils;
public class FileInfo {
private final String filePath;
private final List<Long> chunkOffsets;
private final UserIdentifier userIdentifier;
+ private final PartitionType partitionType;
public FileInfo(String filePath, List<Long> chunkOffsets, UserIdentifier
userIdentifier) {
this.filePath = filePath;
this.chunkOffsets = chunkOffsets;
this.userIdentifier = userIdentifier;
+ this.partitionType = PartitionType.REDUCE;
}
- public FileInfo(String filePath, UserIdentifier userIdentifier) {
+ public FileInfo(
+ String filePath,
+ List<Long> chunkOffsets,
+ UserIdentifier userIdentifier,
+ PartitionType partitionType) {
+ this.filePath = filePath;
+ this.chunkOffsets = chunkOffsets;
+ this.userIdentifier = userIdentifier;
+ this.partitionType = partitionType;
+ }
+
+ public FileInfo(String filePath, UserIdentifier userIdentifier,
PartitionType partitionType) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
