+1 (non-binding) I checked the following things: - git commit hash is correct. - download links are valid. - release files are in correct location. - release files have the word incubating in their name. - signatures and checksums are good. - DISCLAIMER, LICENSE and NOTICE files exist. - build success from source code(ubuntu 16.04). ``` ./build/make-distribution.sh --release ./build/make-distribution.sh -Pspark-3.3 ```
Thanks, Yihe Li On 2024/01/02 08:00:27 Ethan Feng wrote: > +1(binding) > > I checked: > √ release files in the correct location > √ release files have the word incubating > √ digital signature and hashes correct > √ DISCLAIMER file exist > √ LICENSE and NOTICE files exist and are correct > √ the contents of the release match the tag in VCS > √ can build the release from the source > √ maven artifacts look correct > > Thanks, > Ethan Feng > > Shaoyun Chen <c...@apache.org> 于2024年1月2日周二 12:43写道: > > > > +1 (non-binding) > > > > I checked the following things: > > > > - signatures are good. > > ``` > > gpg --import KEYS > > gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc > > gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc > > ``` > > - checksums are good. > > ``` > > sha512sum --check apache-celeborn-0.4.0-incubating-source.tgz.sha512 > > sha512sum --check apache-celeborn-0.4.0-incubating-bin.tgz.sha512 > > ``` > > - build success from source code. > > ``` > > ./build/make-distribution.sh --release > > ./build/make-distribution.sh --sbt-enabled --release > > ``` > > > > Keyong Zhou <zho...@apache.org> 于2024年1月2日周二 10:05写道: > > > > > > +1 (binding) > > > > > > I checked > > > - git commit hash is correct. > > > - links are valid. > > > - "incubating" is in the name. > > > - PGP keys are good. > > > ``` > > > > > > gpg --import KEYS > > > > > > gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc > > > > > > gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc > > > ``` > > > - hashes are correct. > > > ``` > > > > > > sha512sum --check apache-celeborn-0.4.0-incubating-source.tgz.sha512 > > > > > > sha512sum --check apache-celeborn-0.4.0-incubating-bin.tgz.sha512 > > > ``` > > > - LICENSE looks good. > > > - NOTICE looks good. > > > - DISCLAIMER exists. > > > - build success from source code. ``` ./build/make-distribution.sh > > > --sbt-enabled --release ``` > > > > > > Thanks, > > > Keyong Zhou > > > > > > Fu Chen <fc...@apache.org> 于2024年1月1日周一 19:42写道: > > > > > > > Hi Celeborn community, > > > > > > > > This is a call for a vote to release Apache Celeborn (Incubating) > > > > 0.4.0-incubating-rc3 > > > > > > > > > > > > The git tag to be voted upon: > > > > > > > > https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc3 > > > > > > > > > > > > The git commit hash: > > > > 5d94bf9dea735650b90fc4959390da2bfc67fc37 source and binary artifacts > > > > can be > > > > found at: > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc3 > > > > > > > > > > > > The staging repo: > > > > https://repository.apache.org/content/repositories/orgapacheceleborn-1050 > > > > > > > > > > > > Fingerprint of the PGP key release artifacts are signed with: > > > > 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B > > > > > > > > > > > > My public key to verify signatures can be found in: > > > > https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS > > > > > > > > > > > > The vote will be open for at least 72 hours or until the necessary > > > > number of votes are reached. > > > > > > > > > > > > Please vote accordingly: > > > > > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and the reason) > > > > > > > > > > > > Checklist for release: > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > Steps to validate the release: > > > > https://www.apache.org/info/verification.html > > > > > > > > > > > > * Download links, checksums and PGP signatures are valid. > > > > * Source code distributions have correct names matching the current > > > > release. > > > > * Release files have the word incubating in their name. > > > > * DISCLAIMER, LICENSE and NOTICE files are correct. > > > > * All files have license headers if necessary. > > > > * No unlicensed compiled archives bundled in source archive. > > > > * The source tarball matches the git tag. > > > > * Build from source is successful. > > > > > > > > Please be aware that there has been a transition in the Celeborn > > > > project's > > > > build tool, shifting from Maven to SBT. The SBT build documentation is > > > > available > > > > at https://celeborn.apache.org/docs/latest/developers/sbt/. > > > > > > > > For illustrative purposes: > > > > > > > > Packaging the project > > > > ``` > > > > ./build/sbt clean package > > > > ``` > > > > > > > > Creating the distribution > > > > ``` > > > > ./build/make-distribution.sh --sbt-enabled --release > > > > ``` > > > > > > > > Thanks, > > > > Fu Chen > > > > >