Hi Aravind, Thanks for driving this CIP about Celeborn CLI. I have some comments on this CIP:
1. From a user's perspective, the CLI is more used for some maintenance operations such as online and offline of server, rescaling of cluster etc, not only based on the REST API. What CLI interfaces are there that the REST API doesn’t have for maintenance? 2. There are same sub-commands between MASTER and WORKER. Why not these sub-commands belong to BOTH? 3. Does the implementation of CLI invoke the REST API? IMO, the CLI works well no matter the server is alive. BTW, could this design doc of proposal follow the template of CIP[1]? [1] https://cwiki.apache.org/confluence/display/CELEBORN/Celeborn+Improvement+Proposals Regards, Nicholas Jiang On 2024/06/05 23:33:02 Aravind Patnam wrote: > Hi all, > > I have written up a proposal about introducing a CLI for Celeborn. You can > find the proposal > <https://docs.google.com/document/d/1j9wKFSR_ychYDF0NU5YN67WCCtNAgYTbN5CN8V3SOnk/edit?usp=sharing> > here. > Please let me know if you have any comments or questions. > > TLDR by introducing a CLI, it would complement the existing dashboard and > would benefit us internally. We rely on CLI tools internally a lot for > automation and other operations. > > FYI, I was not able to access the cwiki page to put this proposal there, > there seems to be some permissions issue. Hope it is okay to just share as > a google doc here for now. > > -- > Aravind K. Patnam > > Apache Celeborn CLI Proposal > <https://docs.google.com/document/d/1j9wKFSR_ychYDF0NU5YN67WCCtNAgYTbN5CN8V3SOnk/edit?usp=drive_web> >
