Hi Ethan, Thanks for the effort! Although others LGTM, I found some issues in the LICENSE file:
1. ratis-metrics-default, ap-loader-all, jersey-server, jersey-container-servlet-core, jersey-hk2, jersey-media-json-jackson, jersey-media-multipart are missing in the LICENSE file 2. javax.servlet is deleted, so it should also be removed from the LICENSE-binary file Regards, Keyong Zhou Ethan Feng <[email protected]> 于2024年6月7日周五 15:56写道： > Hello, Celeborn community, > > This is a call for a vote to release Apache Celeborn > 0.5.0-rc0 > > The git tag to be voted upon: > https://github.com/apache/celeborn/releases/tag/v0.5.0-rc0 > > Source and binary artifacts can be found at: > https://dist.apache.org/repos/dist/dev/celeborn/v0.5.0-rc0 > > The git commit hash: > 36567733aace2c83e533cbefcc5cd374ca935c76 > > The staging repo: > https://repository.apache.org/content/repositories/orgapacheceleborn-1066/ > > The fingerprint of the PGP key release artifacts is signed with: > FCF20BB29C7BEFDF58F998F76392F71F37356FA0 > > My public key to verify signatures can be found in: > https://dist.apache.org/repos/dist/release/celeborn/KEYS > > The vote will be open for at least 72 hours or until the necessary > number of votes are reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and the reason) > > Steps to validate the release: > https://www.apache.org/info/verification.html > > * Download links, checksums, and PGP signatures are valid. > * Source code distributions have correct names matching the current > release. > * LICENSE and NOTICE files are correct. > * All files have license headers if necessary. > * No unlicensed compiled archives bundled in the source archive. > * The source tarball matches the git tag. > * Build from source is successful. > > There are additional tests: > * Performance test no regression > 1 TB TPC-DS, 0.5.0 VS 0.4.1 : 2042(s) VS 2050(s) > 1.1 TB pure shuffle, 0.5.0 VS 0.4.1 : 11.8min vs 11.8min > > * Result correctness test passed > 1TB TPC-DS runs concurrently, the results are identical. > > * Usability test passed > Rolling upgrade from version 0.4.1 to 0.5.0 succeed. > The metrics system works as expected. > > * Stability test passed > Random worker failures, Celeborn works as expected. > Random master failures, Celeborn works as expected. > Master meta corrupted, Celeborn works as expected. > > * Compatibility test passed > The Celeborn server version of 0.5.0 works fine with the Celeborn client > 0.4.1. > > > Regards, > Ethan Feng >
