Hi Sanskar, Thank you for the proposal! Tags can be very useful for rolling upgrades and resource allocation scenarios. Overall, the design proposal looks good to me. I’ve left some minor comments to clarify certain parts of the design. Additionally, this document has been reviewed for a while, I believe that the overall design is doable, so I think we can initiate a CIP vote now.
Thanks, Jiashu Xiong Ethan Feng <ethanf...@apache.org> 于2024年9月3日周二 11:27写道： > Hi Sanskar, > > Thanks for your enthusiasm. > > Before starting the development, there can be a vote to ensure that > the majority of the Celeborn community has reached a consensus. > > Do you need help to move the design docs to the confluence like other > CIPs[0]? > > Regards, > Ethan Feng > > [0] > https://cwiki.apache.org/confluence/display/CELEBORN/Celeborn+Improvement+Proposals > > Sanskar Modi <sanskarmod...@gmail.com> 于2024年9月2日周一 20:46写道： > > > > Hi all, > > > > Thanks for reviewing the doc. I've addressed most of the comments, please > > let me know if there are any final comments. If not, I'll start working > on > > the development. > > > > Regards, > > Sanskar Modi > > > > On Tue, Aug 20, 2024 at 11:08 PM Sanskar Modi <sanskarmod...@gmail.com> > > wrote: > > > > > Hi all, > > > > > > I've written up a proposal for supporting tags in Celeborn. You can > find > > > the proposal here > > > < > https://docs.google.com/document/d/1aCnxFSKqK687aJS01U0Z_EyHTKhvq1PEk-2I7pI3Mr0/edit#heading=h.989t4btat0zg > >. > > > Please let me know what you think about this and if we can improve the > > > design. > > > > > > Supporting tags can enable Celeborn to create isolated environments > with > > > different spec / configs / releases and manage the worker fleet with > ease. > > > > > > Regards, > > > Sanskar Modi > > > >
