As the main branch has your PR, this PR will not be cherry-picked to the main branch.
> On Jan 21, 2025, at 17:49, turboFei (via GitHub) <[email protected]> wrote: > > > turboFei commented on code in PR #3070: > URL: https://github.com/apache/celeborn/pull/3070#discussion_r1923395006 > > > ########## > client-spark/spark-3/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala: > ########## > @@ -369,7 +375,22 @@ class CelebornShuffleReader[K, C]( > } > } > > - private def handleFetchExceptions( > + @VisibleForTesting > + def checkAndReportFetchFailureForUpdateFileGroupFailure( > + celebornShuffleId: Int, > + ce: Throwable): Unit = { > + if (ce.getCause != null && > + (ce.getCause.isInstanceOf[InterruptedException] || > ce.getCause.isInstanceOf[ > + TimeoutException])) { > > Review Comment: > the current target branch is barnch-0.5, should it be main? > > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: [email protected] > > For queries about this service, please contact Infrastructure at: > [email protected] >
