rlenferink commented on a change in pull request #45: Fix for curl dependency
URL: https://github.com/apache/celix/pull/45#discussion_r320109195
##########
File path: CMakeLists.txt
##########
@@ -49,6 +52,33 @@ ELSE ()
set(CMAKE_EXE_LINKER_FLAGS "-pthread ${CMAKE_EXE_LINKER_FLAGS}")
ENDIF()
+if(ENABLE_W_ERROR)
+ set(CMAKE_CXX_FLAGS "-Werror ${CMAKE_CXX_FLAGS_DEBUG}")
Review comment:
This probably should be
```CMake
set(CMAKE_CXX_FLAGS "-Werror ${CMAKE_CXX_FLAGS}")
set(CMAKE_CXX_FLAGS_DEBUG "-Werror ${CMAKE_CXX_FLAGS_DEBUG}")
```
Otherwise when setting the `ENABLE_W_ERROR` flag the DEBUG flags are always
included.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
