rlenferink commented on a change in pull request #50: Feature/fix tcp
transmissions
URL: https://github.com/apache/celix/pull/50#discussion_r324850011
##########
File path: CMakeLists.txt
##########
@@ -38,8 +38,10 @@ set(ENABLE_MORE_WARNINGS OFF)
IF (ANDROID)
set(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu99 -Wall ${CMAKE_C_FLAGS}")
ELSE ()
- set(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu99 -Wall -Werror -fPIC
${CMAKE_C_FLAGS}")
- set(CMAKE_CXX_FLAGS "-std=c++11 -Wall -Wextra -Weffc++ -fno-rtti
-fno-exceptions ${CMAKE_CXX_FLAGS}")
+ set(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu99 -fPIC ${CMAKE_C_FLAGS}")
+ set(CMAKE_CXX_FLAGS "-std=c++11 -fno-rtti
-fno-exceptions${CMAKE_CXX_FLAGS}")
Review comment:
A missing space is breaking the build
```suggestion
set(CMAKE_CXX_FLAGS "-std=c++11 -fno-rtti -fno-exceptions
${CMAKE_CXX_FLAGS}")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
