pnoltes commented on pull request #251: URL: https://github.com/apache/celix/pull/251#issuecomment-640462987
> > > > > I'm going to object this one. Not sure what the issue is, some details might convinced me otherwise. > > > > > But, in_list is already in cmake since 3.3. And more importantly, we should not want to fix down stream issues with such old versions. Some backwards compatibility with older versions is good, but this goes back to far. > > > > > > > > > > > > Tested with cmake 3.4 and 3.12 and in both cases the cmake policy CMP0057 has te be set (I expect to NEW) or the build fails. > > > > Normally not a big issues, just set the policy in Celix. > > > > But because the BundlePackaging.cmake is a Celix delivery and used by end users, this means that all users using at least cmake <= 3.12 need to set this policy in their environment or else the build will fail. > > > > > > > > > 3.12 has been release in november 2018, I don't see a big problem here. If it was less then a year ago, perhaps, but not now. > > > > > > Note sure why building celix has no issue there, but reading the cmake help: > > https://cmake.org/cmake/help/v3.17/policy/CMP0057.html > > cmake 3.17 (latest) still set the default value of the policy to old (so ignoring it as an operator value). If I am correct this means that all users need to set this policy to get the Bundle Packaging working. > > Wow, I did not expect that, in that case I don't have a huge argument I guess.. > Can it be that one of the included (external) files sets the policy? If so, can't we do the same? Technically I think we can, but I think you should not set a cmake policy for a user. Although in this case a stretch, an end user project can depend on the OLD policy and explicitly set it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
