rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r438988878
##########
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_receiver.c
##########
@@ -650,6 +650,8 @@ static void* psa_zmq_recvThread(void * data) {
} else {
message.metadata.metadata = NULL;
}
+ zframe_t *footer = zmsg_pop(zmsg); // footer
+ receiver->protocol->decodeFooter(receiver->protocol->handle,
zframe_data(footer), zframe_size(footer), &message);
Review comment:
I think this is correct, the code is also changed to make footer optional
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]