pnoltes commented on a change in pull request #253: URL: https://github.com/apache/celix/pull/253#discussion_r440037844
########## File path: bundles/pubsub/pubsub_protocol_wire_v2/CMakeLists.txt ########## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +add_library(celix_wire_protocol_v2_impl STATIC + src/pubsub_wire_v2_protocol_impl.c + src/pubsub_wire_v2_protocol_common.c) +target_include_directories(celix_wire_protocol_v2_impl PRIVATE src) +target_link_libraries(celix_wire_protocol_v2_impl PRIVATE Celix::pubsub_spi Celix::pubsub_utils) +target_include_directories(celix_wire_protocol_v2_impl PRIVATE src ${CMAKE_SOURCE_DIR}/bundles/pubsub/pubsub_protocol_wire_v1/src ) Review comment: Do not use abs paths to include dir, this is too fragile. Always prefer a cmake target when referring to include paths (e.g. a pubsub_protocol_common INTERFACE/STATIC library) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
