pnoltes commented on a change in pull request #360:
URL: https://github.com/apache/celix/pull/360#discussion_r704135276
##########
File path: libs/promises/api/celix/DefaultScheduledExecutor.h
##########
@@ -108,9 +111,12 @@ namespace celix {
void wait() override {
bool done = false;
while (!done) {
- std::lock_guard<std::mutex> lck{mutex};
+ std::unique_lock lck{mutex};
Review comment:
should be lock_guard instead of unique_lock (left over from some
reverted refactoring)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
