rlenferink commented on a change in pull request #363:
URL: https://github.com/apache/celix/pull/363#discussion_r723917947
##########
File path: libs/pushstreams/docs/pushstreams.adoc
##########
@@ -0,0 +1,140 @@
+= PushStreams
Review comment:
Including AsciiDoc docs on the Celix website is something we haven't
done before. That might mean some testing and then possibly installing an
AsciiDoc plugin somewhere.
See https://gohugo.io/content-management/formats/#list-of-content-formats
Goldmark is what we currently use for our Markdown files.
##########
File path: libs/pushstreams/docs/pushstreams.adoc
##########
@@ -0,0 +1,140 @@
+= PushStreams
Review comment:
I also think it’s okay picking this up after this is merged, also
because there are other AsciiDoc files in the Celix repo already.
I created issue https://github.com/apache/celix-site/issues/12 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
