rlenferink commented on a change in pull request #373:
URL: https://github.com/apache/celix/pull/373#discussion_r725687154
##########
File path: libs/promises/api/celix/impl/SharedPromiseState.h
##########
@@ -892,7 +892,7 @@ void
celix::impl::SharedPromiseState<T>::addOnFailureConsumeCallback(std::functi
} catch (const std::exception &e) {
callback(e);
} catch (...) {
- //NOTE not an exception based on std::exception, "repacking"
it to logical error
+ //NOTE not a exception based on std::exception, "repacking" it
to logical error
Review comment:
`an exception` was already correct, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
