stegemr commented on a change in pull request #372:
URL: https://github.com/apache/celix/pull/372#discussion_r725836099
##########
File path:
bundles/cxx_remote_services/integration/src/TestExportImportRemoteServiceFactory.cc
##########
@@ -29,7 +31,7 @@
#include "pubsub/publisher.h"
#include "pubsub/subscriber.h"
-constexpr auto INVOKE_TIMEOUT = std::chrono::seconds{10};
+constexpr auto INVOKE_TIMEOUT = std::chrono::seconds{5}; //TODO make
configurable
Review comment:
removed the todo, as @pnoltes sugested
##########
File path:
bundles/cxx_remote_services/integration/gtest/src/RemoteServicesIntegrationTestSuite.cc
##########
@@ -115,16 +115,27 @@ TEST_F(RemoteServicesIntegrationTestSuite,
InvokeRemoteCalcService) {
cmd.executeCommand(cmd.handle, "psa_zmq", stdout, stdout);
})
.build();
-
+ std::shared_ptr<celix::PushStream<double>> stream;
//When I call the calculator service from the client, I expect a answer
+ int streamCount = 0;
+ double lastValue = 0.0;
Review comment:
yes, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
