jermus67 commented on a change in pull request #385:
URL: https://github.com/apache/celix/pull/385#discussion_r774231376



##########
File path: libs/utils/include/celix/Filter.h
##########
@@ -118,6 +118,32 @@ namespace celix {
             return celix_filter_findAttribute(cFilter.get(), 
attributeKey.c_str()) != nullptr;
         }
 
+        /**
+         * @brief Check whether the filter indicates the mandatory presence of 
an attribute with a specific value for the provided attribute key.
+         *
+         * Example:
+         *   using this method for attribute key "key1" on filter 
"(key1=value1)" yields true.
+         *   using this method for attribute key "key1" on filter 
"(!(key1=value1))" yields false.
+         *   using this method for attribute key "key1" on filter 
"(key1>=value1)" yields false.
+         *   using this method for attribute key "key1" on filter 
"(|(key1=value1)(key2=value2))" yields false.
+         */
+        [[nodiscard]] bool hasMandatoryEqualsValueAttribute(const std::string& 
attributeKey) const {

Review comment:
       changed to std::string_view




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to