pnoltes commented on a change in pull request #392:
URL: https://github.com/apache/celix/pull/392#discussion_r790317824
##########
File path: CMakeLists.txt
##########
@@ -44,7 +44,7 @@ endif ()
set(ENABLE_MORE_WARNINGS OFF)
# Set C specific flags
-set(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu99 -fPIC ${CMAKE_C_FLAGS}")
+set(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu11 -fPIC ${CMAKE_C_FLAGS}")
Review comment:
Note: that this will update the C requirements for Celix from gnu99 to
gnu11.
I have no issue with this, but maybe it good to get some broader feedback on
this.
@rlenferink , @rbulter , @ErjanAltena and @stegemr Do any of you have any
issues updating the Celix C standard from gnu99 to gnu11? .
... And if we have no issues, should we also introduce the use of `#pragma
once` for C code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
