rlenferink opened a new pull request #398: URL: https://github.com/apache/celix/pull/398
This adds an [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features) file for the Celix repo, mainly to have clear which settings/permissions/features we have enabled. This contains the current settings for the celix repo, except the description and the labels, which I updated while creating the file. The branch protection settings allow to have settings specified more extensively (see [the available settings](https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features#Git.asf.yamlfeatures-BranchProtection)). What this pull request contains is what is currently in place for celix: branch protection of the `master` branch to prevent force pushes. One thing that other repos often have additionally enabled in their branch_protection settings is `required_pull_request_reviews`: ```yaml protected_branches: master: # When enabled, all commits must be made to a non-protected branch and submitted # via a pull request before they can be merged into a branch that matches this rule. required_pull_request_reviews: # Additional optional setting: # When enabled, pull requests targeting a matching branch require a number # of approvals and no changes requested before they can be merged. required_approving_review_count: 1 ``` I think the `required_pull_request_reviews` might be useful, to at least protect ourselves against not accidentally committing to the `master` branch (I always double check on which branch I am before pushing something, but it is easy to forget). I don't think the `required_approving_review_count` is necessary for Celix, but i am interested on your opinions as well @pnoltes and @abroekhuis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
