PengZheng commented on a change in pull request #401:
URL: https://github.com/apache/celix/pull/401#discussion_r827052728
##########
File path: cmake/cmake_celix/BundlePackaging.cmake
##########
@@ -908,8 +908,9 @@ function(install_celix_bundle_targets)
get_target_property(EXPORT_BUNDLES celix-bundles
EXPORT_${EXPORT_NAME}_BUNDLES)
- if (NOT DEFINED EXPORT_BUNDLES)
- message(FATAL_ERROR "Export ${EXPORT_NAME} not defined. Did you forgot
to use a install_celix_bundle with the 'EXPORT ${EXPORT_NAME}' option?")
+ if (NOT DEFINED EXPORT_BUNDLES OR NOT EXPORT_BUNDLES)
Review comment:
Now that it is possible to turn off all bundles, this is not FATAL error
any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
