PengZheng commented on pull request #373:
URL: https://github.com/apache/celix/pull/373#issuecomment-1073020573


   > > Will this still work for C++11 compiler? @pnoltes
   > 
   > The C++ Dependency manager will be kept on C++11, because the C++ 
Dependency Manager was already released in Celix 2.2.1. The rest of the C++ 
headers (C++ BundleContext, C++ Trackers, C++ Filters, C++ ServiceRegistration) 
will be C++ 17.
   
   I noticed the following error when testing my conan package with CELIX_CXX 
off. It seems that the C++ dependency manager is now also C++17, isn't it?
   
   ```
   In file included from 
/home/peng/.conan/data/celix/2.2.3/zhengpeng/testing/build/ce358756ed57e6c77dbb057bb4e49529e4cc4a67/libs/framework/include/celix/dm/Properties.h:22:0,
                    from 
/home/peng/.conan/data/celix/2.2.3/zhengpeng/testing/build/ce358756ed57e6c77dbb057bb4e49529e4cc4a67/libs/framework/include/celix/dm/ServiceDependency.h:38,
                    from 
/home/peng/.conan/data/celix/2.2.3/zhengpeng/testing/build/ce358756ed57e6c77dbb057bb4e49529e4cc4a67/libs/framework/include/celix/dm/Component.h:35,
                    from 
/home/peng/.conan/data/celix/2.2.3/zhengpeng/testing/build/ce358756ed57e6c77dbb057bb4e49529e4cc4a67/libs/framework/include/celix/dm/DependencyManager.h:23,
                    from 
/home/peng/.conan/data/celix/2.2.3/zhengpeng/testing/build/ce358756ed57e6c77dbb057bb4e49529e4cc4a67/libs/framework/include/celix/BundleActivator.h:24,
                    from 
/home/peng/.conan/data/celix/2.2.3/zhengpeng/testing/build/ce358756ed57e6c77dbb057bb4e49529e4cc4a67/libs/framework/gtest/src/CmpTestBundleActivator.cc:20:
   
/home/peng/.conan/data/celix/2.2.3/zhengpeng/testing/build/ce358756ed57e6c77dbb057bb4e49529e4cc4a67/libs/utils/include/celix/Properties.h:140:50:
 error: ‘nodiscard’ attribute directive ignored [-Werror=attributes]
                [[nodiscard]] const char* getValue() const {
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to