pnoltes commented on PR #439:
URL: https://github.com/apache/celix/pull/439#issuecomment-1233270415
> I'll merge it so that I can deploy the latest Celix in my working
environment.
>
> If there is any change request, please leave it here. I'll address it ASAP.
A bit late with my reaction, but I would prefer the same default behaviour
from building with conan and cmake-only.
And for me it is fine to make the default to use compression (indeed to
prevent changes to the users) for both cmake and conan.
That being said, I actually think the PR #427 was merged too quickly.
Because IMO configuring the jar/zip command arguments leaks too much details /
requires too much knowledge from the users.
I think something like a
CELIX_USE_COMPRESSION_FOR_BUNDLE_ZIPS/celix_use_compression_for_bundle_zips:
[True, False] cmake/conan option is more user friendly.
@stegemr Do you agree with this and so yes, maybe we can update this I a new
PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
