pnoltes commented on code in PR #437:
URL: https://github.com/apache/celix/pull/437#discussion_r967857155
##########
bundles/remote_services/CMakeLists.txt:
##########
@@ -18,16 +18,20 @@
celix_subproject(REMOTE_SERVICE_ADMIN "Option to enable building the Remote
Service Admin Service bundles" ON)
if (REMOTE_SERVICE_ADMIN)
+ add_subdirectory(thpool)
add_subdirectory(remote_services_api)
- add_subdirectory(deprecated_rsa_spi)
+ add_subdirectory(rsa_spi)
add_subdirectory(rsa_common)
+ add_subdirectory(rsa_dfi_utils)
add_subdirectory(civetweb)
add_subdirectory(discovery_common)
add_subdirectory(discovery_configured)
add_subdirectory(discovery_etcd)
add_subdirectory(examples)
add_subdirectory(topology_manager)
add_subdirectory(remote_service_admin_dfi)
+ add_subdirectory(rsa_rpc_json)
+ add_subdirectory(remote_service_admin_shm_v2)
celix_subproject(RSA_SHM "Option to enable building the Discovery (SHM)
bundle" OFF)
if (RSA_SHM)
Review Comment:
> We should remove the old implementation and add working example for the
current version. WDYT @pnoltes @xuzhenbao
I agree with removing the old implementation. It is not working and there
new implementation has the same purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
