pnoltes commented on code in PR #449:
URL: https://github.com/apache/celix/pull/449#discussion_r1037417476
##########
libs/utils/src/celix_log_utils.c:
##########
@@ -95,6 +97,7 @@ celix_log_level_e
celix_logUtils_logLevelFromStringWithCheck(const char *str, ce
}
static inline void celix_logUtils_inlinePrintBacktrace(FILE *stream) {
+#ifndef __UCLIBC__
Review Comment:
Maybe it is better to place the while function in a ifdef, else, endif so
that the function argument can be marked as unused for the uclibc case.
e.g.
```
#ifndef __UCLIBC__
static inline void celix_logUtils_inlinePrintBacktrace(FILE *stream) {
...
}
#else
static inline void celix_logUtils_inlinePrintBacktrace(FILE *stream
__attribute__((unused))) {
//nop
}
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
