PengZheng commented on code in PR #451:
URL: https://github.com/apache/celix/pull/451#discussion_r1040843895
##########
libs/framework/gtest/CMakeLists.txt:
##########
@@ -15,6 +15,8 @@
# specific language governing permissions and limitations
# under the License.
Review Comment:
It seems that a `CELIX_CXX17` testing is missing.
##########
examples/celix-examples/CMakeLists.txt:
##########
@@ -19,7 +19,7 @@ if (COMMAND celix_subproject)
celix_subproject(EXAMPLES "Option to enable building the Examples" ON DEPS
SHELL SHELL_TUI LOG_SERVICE)
else ()
set(EXAMPLES true) #celix_subproject is only available in the celix
project -> using examples dir in other project is also supported
- option(CELIX_CXX ON)
+ option(CELIX_CXX14 ON)
Review Comment:
missing `CELIX_CXX17`?
##########
conanfile.py:
##########
@@ -160,8 +162,9 @@ def configure(self):
for opt, val in self.options.values.items():
if opt.startswith('build_'):
setattr(self.options, opt, True)
- if not self.options.celix_cxx:
+ if not self.options.celix_cxx14:
Review Comment:
```suggestion
if not self.options.celix_cxx14:
self.options.celix_cxx17 = false
```
##########
conanfile.py:
##########
@@ -160,8 +162,9 @@ def configure(self):
for opt, val in self.options.values.items():
if opt.startswith('build_'):
setattr(self.options, opt, True)
- if not self.options.celix_cxx:
+ if not self.options.celix_cxx14:
self.options.build_cxx_remote_service_admin = False
+ if not self.options.celix_cxx17:
Review Comment:
```suggestion
if not self.options.celix_cxx17:
self.options.build_cxx_remote_service_admin = False
```
According to the corresponsing CMakeLists.txt, cxx_remote_service_admin is
C++17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
