pnoltes commented on code in PR #476:
URL: https://github.com/apache/celix/pull/476#discussion_r1113409403
##########
bundles/shell/shell/src/start_command.c:
##########
@@ -23,42 +23,37 @@
#include "celix_api.h"
#include "std_commands.h"
+#include "celix_convert_utils.h"
-bool startCommand_execute(void *handle, const char *const_command, FILE
*outStream, FILE *errStream) {
+bool startCommand_execute(void *handle, const char *constCommandLine, FILE
*outStream, FILE *errStream) {
Review Comment:
I agree, we could introduce a 3.0.0 version of the Celix shell command that
does this.
But I think a 3.0.0 version can be better done post Celix 3.0.0 release and
then support a shell command version 2.0.0 and 3.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
