PengZheng commented on code in PR #476: URL: https://github.com/apache/celix/pull/476#discussion_r1115554954
########## libs/framework/include/bundle_revision.h: ########## @@ -109,7 +101,8 @@ celix_status_t bundleRevision_getManifest(bundle_revision_pt revision, manifest_ * - CELIX_SUCCESS when no errors are encountered. * - CELIX_ILLEGAL_ARGUMENT If <code>revision</code> is illegal. */ -celix_status_t bundleRevision_getHandles(bundle_revision_pt revision, celix_array_list_t **handles); +celix_status_t bundleRevision_getHandles(const bundle_revision_t* revision, celix_array_list_t **handles) Review Comment: Now that the implementation is removed from bundle_revision.c, it will cause linking error for any existing application using it. I think the declaration should also be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
